I-ALiRT - Update codice l2 #2501
Conversation
laspsandoval
added
Ins: CoDICE
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
I have a few suggestions that I think might make this a little cleaner without all the case handlings.
-
Stick to numpy arrays. So try to initialize an empty array with the expected shape.
pseudo_density_arr = np.empty((len(constants.LO_IALIRT_VARIABLE_NAMES), len(intensity))
Then you can ignore the division by zero and let nan's fall out automatically and replace with fills later if you want. (remove all if 0 branches) -
Use an IntEnum for your species names. Then you can lookup into arrays with
pseudo_density_arr[LoSpecies.O_7_plus, :]rather thanpseudo_density_dict[species_list[3]]with kind of two redirects in there which is confusing for me to follow without looking back up what index is what in the species list.
| pseudo_density_dict[species_list[3]] | ||
| + pseudo_density_dict[species_list[4]] | ||
| + pseudo_density_dict[species_list[5]] |
There was a problem hiding this comment.
I thought I commented on this somewhere else earlier but couldn't find it immediately. I think this would be much easier to follow with an IntEnum to index into the named species.
class Species(IntEnum):
OXYGEN = 0
CARBON2 = 1
...
pseudo_density_arr[Species.OXYGEN]There was a problem hiding this comment.
You are right. It's not too readable. I decided to just write out the names.
|
@greglucas sorry it took me so long to get back to this. Would you mind looking it over again? |
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Yes, much easier to read with string names, thank you for updating that!
laspsandoval
merged commit e71b60e
into
IMAP-Science-Operations-Center:dev
3 participants
Change Summary
Overview
Formatting to get codice_lo into a format that can be inserted into DynamoDB.
Updated Files
Testing